Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-42470: Fix link of owner #1993

Merged

Conversation

metalice
Copy link
Member

@metalice metalice commented Jun 3, 2024

📝 Description

Fix owner resource link

🎥 Demo

Before:
image

After:
image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 3, 2024

@metalice: This pull request references CNV-42470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Fix owner resource link

🎥 Demo

Before:
image

After:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and tnisan June 3, 2024 05:19
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 3, 2024
@metalice metalice force-pushed the CNV-42470-fix-link-owner branch from 5eea1c6 to 2660fd4 Compare June 3, 2024 05:23
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 3, 2024
@metalice metalice closed this Jun 3, 2024
@metalice metalice force-pushed the CNV-42470-fix-link-owner branch from 2660fd4 to 8334fc5 Compare June 3, 2024 08:32
@openshift-ci openshift-ci bot removed lgtm Passed code review, ready for merge approved This issue is something we want to fix labels Jun 3, 2024
Signed-off-by: Matan Schatzman <[email protected]>
@metalice metalice reopened this Jun 3, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 3, 2024

@metalice: This pull request references CNV-42470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Fix owner resource link

🎥 Demo

Before:
image

After:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 3, 2024
@avivtur
Copy link
Member

avivtur commented Jun 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 5, 2024
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d9b8839 into kubevirt-ui:main Jun 5, 2024
9 of 10 checks passed
@gouyang
Copy link
Member

gouyang commented Jun 5, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #2004

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants